Wire rush-reporter package dependencies - #5985
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
|
All required CI is green and independent integration review is complete. This PR is now the first gate for the validated reporter stack: #5986 → #5987 → #5989 → #5988 → #5991 → #5992 → #5996 → #5997, with #5993/#6000/#5999/#5998 branching from the appropriate tips. The slice remains limited to package dependency/lockfile/boundary wiring and preserves runtime/default output behavior. Squash auto-merge is enabled; requesting maintainer approval so the fleet can begin sequential retargeting and full-CI validation of each child. |
|
Combined deep review of current head No critical, high, or medium actionable findings. No useful low follow-ons. |
|
Ian Clanton-Thuon (@iclanton) David Michon (@dmichon-msft) Maintainer review is now the only gate on this root stack. #5985 is clean with full CI green and auto-merge enabled. Every descendant current head has completed repeated deep review with no actionable issue above low. Could one of you review the root so sequential retargeting can begin? The independent privacy root #5990 is also full-CI green, low-only, and auto-merge enabled. |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The dependency wiring, generated metadata, and boundary tests are consistent, with no unresolved issues.
Review tier: Balanced
Findings: None
What changed in this PR
Wires @rushstack/rush-reporter into Rush and rush-lib without runtime behavior changes.
Changes:
- Adds direct workspace dependencies.
- Updates lockfiles and generated metadata.
- Adds package-boundary coverage.
| File | Description |
|---|---|
libraries/rush-lib/package.json |
Adds the reporter dependency. |
libraries/reporter/src/test/PackageBoundaries.test.ts |
Verifies dependency wiring and independence. |
common/config/subspaces/default/pnpm-lock.yaml |
Updates default-subspace importers. |
common/config/subspaces/build-tests-subspace/repo-state.json |
Refreshes generated state hashes. |
common/config/subspaces/build-tests-subspace/pnpm-lock.yaml |
Updates injected dependency resolution. |
common/config/rush/browser-approved-packages.json |
Approves the reporter dependency. |
common/changes/@microsoft/rush/copilot-reporter-r1a-package-wiring_2026-08-28-02-20.json |
Records the patch change. |
apps/rush/package.json |
Adds the frontend dependency. |
Files not reviewed (2)
- common/config/subspaces/build-tests-subspace/pnpm-lock.yaml: Generated file
- common/config/subspaces/default/pnpm-lock.yaml: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Summary
@rushstack/rush-reporteras a workspace dependency of@microsoft/rush-liband@microsoft/rushrush-libValidation
rush build --to @microsoft/rush --verboserush test --only @rushstack/rush-reporter --verbose(293 tests passed)rush checkrush change --verify --no-fetchNon-goals
Part of #5974